linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1382687810.7782.5.camel@oc7383187364.ibm.com>
Date:	Fri, 25 Oct 2013 09:56:50 +0200
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Frank Haverkamp <haver@...t.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	cody@...ux.vnet.ibm.com,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	utz.bacher@...ibm.com, jsvogt@...ibm.com, MIJUNG@...ibm.com,
	Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>,
	michael@...ra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver

Hi Bjorn,

Am Mittwoch, den 23.10.2013, 12:27 -0600 schrieb Bjorn Helgaas:
> On Thu, Jul 25, 2013 at 2:28 AM, Frank Haverkamp <haver@...t.ibm.com> wrote:

> > Known Restrictions:
> >
> >  o On my PowerPC testsystem SRIOV did not work.
> 
> Does this restriction still apply?  Is there some PCI core issue here?
>  We did fix an SR-IOV issue that was reported on PowerPC with
> aa914f5ec25, so maybe that's related.  But if there's still a PCI core
> issue here, let me know.
> 
> Bjorn


I should remove this old comment. The Linux version I had to test that
was very old. Also I adjusted the driver to the new recommended
interface which allows to turn on the virtual functions via write to a
sysfs entry allows to use the driver in any case. That allowed me to
remove some ugly ifdefs in the code and the comment was meant to explain
those.

Thanks for pointing this out.

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/