linux-kernel - Re: [PATCH] mmc: sdhci: dove: Fix build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppqqkh2g.fsf@octavius.laptop.org>
Date:	Sun, 27 Oct 2013 08:56:55 -0400
From:	Chris Ball <cjb@...top.org>
To:	Thierry Reding <thierry.reding@...il.com>,
	Jeremie Samuel <jeremie.samuel.ext@...rot.com>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage

Hi,

On Wed, Oct 23 2013, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  drivers/mmc/host/sdhci-dove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
>  {
>  	struct sdhci_host *host = data;
>  
> -	schedule_schedule(&host->card_detect_work);
> +	schedule_work(&host->card_detect_work);
>  	return IRQ_HANDLED;
>  }

Thanks, Thierry -- I hope it's okay with you if I merge your fix into
the original patch and add your S-o-b to that patch:

    Signed-off-by: Anton Vorontsov <avorontsov@...sta.com>
    Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@...rot.com>
    [treding: Fix typo causing sdhci-dove build breakage]
    Signed-off-by: Thierry Reding <treding@...dia.com>
    Signed-off-by: Chris Ball <cjb@...top.org>

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/