lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20131028074744.GD6629@ulmo.nvidia.com>
Date:	Mon, 28 Oct 2013 08:47:44 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Chris Ball <cjb@...top.org>
Cc:	Jeremie Samuel <jeremie.samuel.ext@...rot.com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci: dove: Fix build breakage

On Sun, Oct 27, 2013 at 08:56:55AM -0400, Chris Ball wrote:
> Hi,
> 
> On Wed, Oct 23 2013, Thierry Reding wrote:
> > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> > converts tasklets to work structs, but typos the conversion in the Dove
> > driver.
> >
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > ---
> >  drivers/mmc/host/sdhci-dove.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> > index 45c7f25..95f1076 100644
> > --- a/drivers/mmc/host/sdhci-dove.c
> > +++ b/drivers/mmc/host/sdhci-dove.c
> > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> >  {
> >  	struct sdhci_host *host = data;
> >  
> > -	schedule_schedule(&host->card_detect_work);
> > +	schedule_work(&host->card_detect_work);
> >  	return IRQ_HANDLED;
> >  }
> 
> Thanks, Thierry -- I hope it's okay with you if I merge your fix into
> the original patch and add your S-o-b to that patch:
> 
>     Signed-off-by: Anton Vorontsov <avorontsov@...sta.com>
>     Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@...rot.com>
>     [treding: Fix typo causing sdhci-dove build breakage]
>     Signed-off-by: Thierry Reding <treding@...dia.com>
>     Signed-off-by: Chris Ball <cjb@...top.org>

Sure, no problem.

Thierry

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ