linux-kernel - Re: [PATCH] staging: drm/imx: fix return value check in imx_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Oct 2013 08:57:35 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	gregkh@...uxfoundation.org, airlied@...hat.com,
	daniel.vetter@...ll.ch, p.zabel@...gutronix.de,
	yongjun_wei@...ndmicro.com.cn, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: drm/imx: fix return value check in
 imx_drm_init()

On Fri, Oct 25, 2013 at 05:07:18PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function platform_device_register_simple() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> ---
>  drivers/staging/imx-drm/imx-drm-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
> index a2e52a0..835a1b1 100644
> --- a/drivers/staging/imx-drm/imx-drm-core.c
> +++ b/drivers/staging/imx-drm/imx-drm-core.c
> @@ -837,8 +837,8 @@ static int __init imx_drm_init(void)
>  	INIT_LIST_HEAD(&imx_drm_device->encoder_list);
>  
>  	imx_drm_pdev = platform_device_register_simple("imx-drm", -1, NULL, 0);
> -	if (!imx_drm_pdev) {
> -		ret = -EINVAL;
> +	if (IS_ERR(imx_drm_pdev)) {
> +		ret = PTR_ERR(imx_drm_pdev);
>  		goto err_pdev;
>  	}
>  
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/