linux-kernel - Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bo2995o1.fsf@sejong.aot.lge.com>
Date:	Mon, 28 Oct 2013 17:10:54 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	David Ahern <dsahern@...il.com>, Ingo Molnar <mingo@...e.hu>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Andi Kleen <andi@...stfloor.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote:
> Adding call-graph option support into .perfconfig file,
> so it's now possible use call-graph option like:
>
>   [top]
>         call-graph = fp
>
>   [record]
>         call-graph = dwarf,8192
>
> Above options ONLY setup the unwind method. To enable
> perf record/top to actually use it the command line
> option -g/-G must be specified.
>
> The --call-graph option overloads .perfconfig setup.
>
> Assuming above configuration:
>
>   $ perf record -g ls
>   - enables dwarf unwind with user stack size dump 8192 bytes
>
>   $ perf top -G
>   - enables frame pointer unwind
>
>   $ perf record --call-graph=fp ls
>   - enables frame pointer unwind
>
>   $ perf top --call-graph=dwarf,4096 ls
>   - enables dwarf unwind with user stack size dump 4096 bytes
>
[SNIP]
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -750,6 +750,8 @@ int record_parse_callchain_opt(const struct option *opt,
>  	struct perf_record_opts *opts = opt->value;
>  	int ret;
>  
> +	opts->call_graph_enabled = !unset;
> +

Why not just using symbol_conf.use_callchain?

Thanks,
Namhyung


>  	/* --no-call-graph */
>  	if (unset) {
>  		opts->call_graph = CALLCHAIN_NONE;
> @@ -770,6 +772,8 @@ int record_callchain_opt(const struct option *opt,
>  {
>  	struct perf_record_opts *opts = opt->value;
>  
> +	opts->call_graph_enabled = !unset;
> +
>  	if (opts->call_graph == CALLCHAIN_NONE)
>  		opts->call_graph = CALLCHAIN_FP;
>  
> @@ -777,6 +781,16 @@ int record_callchain_opt(const struct option *opt,
>  	return 0;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/