linux-kernel - RE: [char-misc-next 1/8] mei: debugfs: validate dev is not null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Oct 2013 07:16:07 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [char-misc-next 1/8] mei: debugfs: validate dev is not null

> 
> On Mon, Oct 21, 2013 at 10:05:36PM +0300, Tomas Winkler wrote:
> > make static analyzer happy
> 
> That's a stupid analyzer.
> 
> Sorry, this case can never be true, so don't check for it.  Fix your
> analyzer.
> 
> > and validate dev argument before dereferencing
> 
> Again, no need to do so, it's always set properly.
> 
> sorry, I can't take this.

Fair enough, I didn't like that patch myself now I have other confirmation that this is stupid.
 
Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/