linux-kernel - Re: [PATCH] include/linux/wait.h: add ';' for the statement which missed it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52712293.90808@infradead.org>
Date:	Wed, 30 Oct 2013 08:15:31 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Chen Gang <gang.chen@...anux.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include/linux/wait.h: add ';' for the statement which
 missed it.

On 10/29/13 21:08, Chen Gang wrote:
> Add ';' for the statement, or can not pass compiling. The related error
> (for powerpc allmodconfig):
> 
>     CC      block/blk-mq.o
>   block/blk-mq.c: In function ‘blk_mq_queue_enter’:
>   block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’
>   block/blk-mq.c:108:6: error: void value not ignored as it ought to be
> 
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

I have that same patch on my machine but never posted it.

Thanks.

> ---
>  include/linux/wait.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 7f8caa5..fcc9680 100644
> --- a/include/linux/wait.h
> +++ b/include/linux/wait.h
> @@ -768,7 +768,7 @@ do {									\
>  	int __ret = 0;							\
>  	if (!(condition))						\
>  		__ret = __wait_event_interruptible_lock_irq(wq,		\
> -						condition, lock,)	\
> +						condition, lock,);	\
>  	__ret;								\
>  })
>  
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/