linux-kernel - Re: [PATCH] x86: print microcode revision on PEBs errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383161761.9435.35.camel@joe-AO722>
Date:	Wed, 30 Oct 2013 12:36:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: print microcode revision on PEBs errors

On Wed, 2013-10-30 at 21:31 +0200, Michael S. Tsirkin wrote:
> On Sandy bridge CPUs with old microcode, PEBs
> fails and suggests a microcode update.
> Print out the required and the actual revision to
> make it easier to figure out what's wrong.
[]
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
[]
> @@ -2105,6 +2105,8 @@ static int intel_snb_pebs_broken(int cpu)
>  		}
>  	}
>  
> +	pr_info("PEBS checking: microcode 0x%x min legal 0x%x\n",
> +		cpu_data(cpu).microcode, rev);

Maybe only emit this with microcode < rev
otherwise it gets emitted once for each online cpu

>  	return (cpu_data(cpu).microcode < rev);
>  }
>  



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/