| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Oct 2013 15:38:58 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Tejun Heo <tj@...nel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, <linux-kernel@...r.kernel.org> Subject: WTF: driver-core-next contains recursive directory removal! Greg what is going on? I just looked and Tejuns ill-conceived recursive directory deletion code has been merged into your driver-core-next tree. That code is semantically broken. I reviewed it and I gave the reasons why it was wrong. You came up to me and mentioned at LPC that you agreed with my reasons. And yet I just looked in driver-core-next and there the code is in all of it's broken glory. Please pull out that crap it has no business ever going into a stable kernel. The short version is unless someone has drastically changed pci hotplug since last time I looked the code is dramatically wrong as pci hotplug removes directories in the wrong order remove the parent first. So now we have sysfs code that is remove directories multiple times, and we just finished the conversation about sysfs_assoc_lock where Tejun was just explaining how multiple removal of kobjects is not safe. This sysfs semantic change is an unmaintainable disaster. Linus if you would be so kind as to not merge this disaster when the merge window opens I would very much appreciate it. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists