| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87vc0etli6.fsf@xmission.com> Date: Wed, 30 Oct 2013 15:57:37 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Tejun Heo <tj@...nel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: WTF: driver-core-next contains recursive directory removal! Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes: > I don't think there's an issue here, otherwise both Tejun and I would > have found some issues during testing, same for all of the other > linux-next users for the past few weeks. There issues were subtle and hard to detect especially without instrumenting the code during pci hotplug to look for them. Memory leaks, use after free, and needing pci hotplug to reproduce them made the kinds of bugs I saw when I was working with it easy to go unnoticed in light testing. Beyond that the code has the deep issue that the code breaks normal filesystem expectations in a way that is certain to confuse filesystem people like Al Viro. And yes that code being at all recursive is one of the things that Viro objected to when you had him review sysfs before merging my cleanups long ago. Recursive removal is absolutely unnecessary, and it hides bugs, and makes the code unnecessarily complex for no good reason. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists