linux-kernel - RE: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F934AE11CE617240AE4A874A49F629E4832579@DBDE04.ent.ti.com>
Date:	Thu, 31 Oct 2013 10:57:47 +0000
From:	"R, Sricharan" <r.sricharan@...com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"tony@...mide.com" <tony@...mide.com>,
	"Nayak, Rajendra" <rnayak@...com>,
	"marc.zyngier@....com" <marc.zyngier@....com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"robherring2@...il.com" <robherring2@...il.com>,
	"Shilimkar, Santosh" <santosh.shilimkar@...com>,
	Rob Herring <rob.herring@...xeda.com>
Subject: RE: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for
 Crossbar IP

Hi Thomas,
  Again sorry for top post. 

  I agree and will fix both of the comments below.

  Thanks for the reviews.

Regards,
 Sricharan
________________________________________
From: Thomas Gleixner [tglx@...utronix.de]
Sent: Wednesday, October 30, 2013 9:00 PM
To: R, Sricharan
Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-doc@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-omap@...r.kernel.org; linus.walleij@...aro.org; linux@....linux.org.uk; tony@...mide.com; Nayak, Rajendra; marc.zyngier@....com; grant.likely@...aro.org; mark.rutland@....com; robherring2@...il.com; Shilimkar, Santosh; Rob Herring
Subject: Re: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

On Wed, 30 Oct 2013, Sricharan R wrote:
> +static inline const u32 allocate_free_irq(int cb_no)

I understand the "static inline" part, but "const u32" is more than
fishy. What's wrong with "static inline int" ?

> +{
> +     int i;
> +
> +     for (i = 0; i < cb->int_max; i++) {
> +             if (cb->irq_map[i] == IRQ_FREE) {
> +                     cb->irq_map[i] = cb_no;
> +                     return i;
> +             }
> +     }
> +
> +     return -ENODEV;
> +}

> +static int crossbar_domain_xlate(struct irq_domain *d,
> +                              struct device_node *controller,
> +                              const u32 *intspec, unsigned int intsize,
> +                              unsigned long *out_hwirq,
> +                              unsigned int *out_type)
> +{
> +     unsigned long ret = 0;

Why do you need to initialize ret when you assign a value to it in the
next line?

Thanks,

        tglx--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/