lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Nov 2013 20:01:39 +0400 From: Evgeniy Polyakov <zbr@...emap.net> To: Michal Nazarewicz <mina86@...a86.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts Hi everyone 31.10.2013, 13:12, "Michal Nazarewicz" <mina86@...a86.com>: >>> int ttl; >> ... w1_slave.ttl? For noisy lines this was a 'timeout' after which system considered attached device as failed, the noisier line is the longer is timeout I experimented with meters-long w1 wires and it required several search fails to correctly determine that device disappeared > Now that I look at documentation, I think you are correct, but the > problem is on big-endian 64-bit architectures. The fix is still > valid, but the commit message not so much. Something along the > lines of the following would be better: Guys, you so much overcomplicate things - this field is basically a set of in-memory flags for attached device, there is no need to even think about how it is present in different endianess Or do I miss something fundamental there? I wrote it gazillions years ago and probably already forgot something -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists