linux-kernel - Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 02 Nov 2013 21:19:46 +0400
From:	Рустафа Джамурахметов <zbr@...emap.net>
To:	Michal Nazarewicz <mina86@...a86.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

Hi

02.11.2013, 20:59, "Michal Nazarewicz" <mina86@...a86.com>:
>>  Argh, why would we just don't do that? Its in-memory field, it can be
>>  anything, I wouldn't be surprised if it even can be non-atomic because
>>  of proper locks already being held
>
> If the driver does not require an atomic set_bit operation for setting
> and testing the flag, feel free to prepare a patch replacing the whole
> thing with a plain bool.

Please make sure it is properly protected if it is ever required
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/