linux-kernel - Re: [kconfig] update: results of some syntactical checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20131102174047.70c24ed8@samsung.com>
Date:	Sat, 02 Nov 2013 17:40:47 -0200
From:	Mauro Carvalho Chehab <m.chehab@...sung.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Martin Walch <walch.martin@....de>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Larry Finger <Larry.Finger@...inger.net>,
	linux-media@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [kconfig] update: results of some syntactical checks

Em Sat, 02 Nov 2013 20:20:54 +0100
Paul Bolle <pebolle@...cali.nl> escreveu:

> On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> > drivers/media/common/siano/Kconfig:21-26
> > > config SMS_SIANO_DEBUGFS
> > >	bool "Enable debugfs for smsdvb"
> > >	depends on SMS_SIANO_MDTV
> > >	depends on DEBUG_FS
> > >	depends on SMS_USB_DRV
> > >	depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV
> > 
> > The last line adds the dependency CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV.
> > This expression does not look sound as those two symbols are not declared
> > anywhere. So, the two strings CONFIG_SMS_USB_DRV and CONFIG_SMS_SDIO_DRV
> > are compared, yielding always 'n'. As a result, SMS_SIANO_DEBUGFS will never
> > be enabled.
> 
> Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
> to send the trivial patch to fix this?

Yes, it is a typo...

> 
> > Probably, it was meant to say something like
> > >	depends on SMS_USB_DRV = SMS_SDIO_DRV

But this is not the right thing to do. The Kconfig logic here is that it
should depends on !SMS_SDIO_DRV or SMS_USB_DRV = SMS_SDIO_DRV.

I remember I made a patch like that while testing some things with this
driver, but it seems that I forgot to push. I might have it somewhere on
my test machine.



-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/