linux-kernel - Re: [PATCH] ARM: imx: removed unused MACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131104085146.GT24559@pengutronix.de>
Date:	Mon, 4 Nov 2013 09:51:46 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	kernel@...gutronix.de, linux@....linux.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter

On Mon, Nov 04, 2013 at 06:19:26AM +0100, Michael Opdenacker wrote:
> This removes the MACH_MXLADS Kconfig parameter,
> which was no longer used anywhere in the source code
> and Makefiles.

Hehe, this one is a bit tricky. Indeed MACH_MXLADS isn't used directly
anywhere. Nevertheless having CONFIG_MACH_MXLADS defined makes
machine_is_mxlads() become true when the kernel is started with a
machine id of 1851.

machine_is_mxlads() is unused in the kernel, so this patch indeed
doesn't hurt. Anyway, the code is correct currently, so I suggest
keeping it until the mx[1l]ads is either removed or converted to
devicetree.

Sascha


> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> ---
>  arch/arm/mach-imx/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 29a8af6922a8..d84a772bbc68 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -158,14 +158,11 @@ config	SOC_IMX51
>  if ARCH_MULTI_V4T
>  
>  comment "MX1 platforms:"
> -config MACH_MXLADS
> -	bool
>  
>  config ARCH_MX1ADS
>  	bool "MX1ADS platform"
>  	select IMX_HAVE_PLATFORM_IMX_I2C
>  	select IMX_HAVE_PLATFORM_IMX_UART
> -	select MACH_MXLADS
>  	select SOC_IMX1
>  	help
>  	  Say Y here if you are using Motorola MX1ADS/MXLADS boards
> -- 
> 1.8.1.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/