[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <52776234.7030901@free-electrons.com>
Date: Mon, 04 Nov 2013 10:00:36 +0100
From: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
To: kernel@...gutronix.de, linux@....linux.org.uk,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter
Hi Sascha,
On 11/04/2013 09:51 AM, Sascha Hauer wrote:
> On Mon, Nov 04, 2013 at 06:19:26AM +0100, Michael Opdenacker wrote:
>> This removes the MACH_MXLADS Kconfig parameter,
>> which was no longer used anywhere in the source code
>> and Makefiles.
> Hehe, this one is a bit tricky. Indeed MACH_MXLADS isn't used directly
> anywhere. Nevertheless having CONFIG_MACH_MXLADS defined makes
> machine_is_mxlads() become true when the kernel is started with a
> machine id of 1851.
Oops, that's right, got it! Thanks!
>
> machine_is_mxlads() is unused in the kernel, so this patch indeed
> doesn't hurt. Anyway, the code is correct currently, so I suggest
> keeping it until the mx[1l]ads is either removed or converted to
> devicetree.
Sounds good to me.
Thanks for your review!
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists