linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Nov 2013 17:19:51 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
	arnd@...db.de, cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	utz.bacher@...ibm.com, mmarek@...e.cz, jsvogt@...ibm.com,
	MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com, michael@...ra.de,
	Frank Haverkamp <haver@...t.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

Am Donnerstag, den 31.10.2013, 07:38 +1100 schrieb Ryan Mallon:
> On 31/10/13 04:35, Greg KH wrote:
> 
> > On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
> >> +if GENWQE
> >> +
> >> +config GENWQE_DEVNAME
> >> +        string "Name for sysfs and device nodes"
> >> +	default "genwqe"
> >> +        help
> >> +          Select alternate name for sysfs and device nodes.
> > 
> > Don't let the user pick this, it's up to the driver to set this once and
> > then live with it.
> > 
> > And, from what I can tell in the driver, this help text is wrong (there
> > are no device nodes with this name in it, right?)
> 
> 
> The indentation is also messed up here. Kconfig should use hard tabs, with
> two additional spaces for the help text. This has mixed tabs and spaces
> between lines.
> 

Ok. Removed it anyways.

> ~Ryan
> 
> 

Regards

Frank


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/