linux-kernel - Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383581919.15642.6.camel@oc7383187364.ibm.com>
Date:	Mon, 04 Nov 2013 17:18:39 +0100
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de,
	cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
	utz.bacher@...ibm.com, mmarek@...e.cz, rmallon@...il.com,
	jsvogt@...ibm.com, MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com,
	michael@...ra.de, Frank Haverkamp <haver@...t.ibm.com>
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

Hi Greg,

Am Mittwoch, den 30.10.2013, 10:35 -0700 schrieb Greg KH:
> Don't let the user pick this, it's up to the driver to set this once
> and
> then live with it.

Ok. I will remove it in the next version.

> 
> And, from what I can tell in the driver, this help text is wrong
> (there
> are no device nodes with this name in it, right?) 

There is a /dev/genwqe<n>_card character device:

card_dev.c:
cd->dev = device_create(cd->class_genwqe, &cd->pci_dev->dev,
				cd->devnum_genwqe, NULL,
				GENWQE_DEVNAME "%u_card", cd->card_idx);

That is what I meant with "device node".

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/