[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131104070500.GE13030@gmail.com>
Date: Mon, 4 Nov 2013 08:05:00 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Davidlohr Bueso <davidlohr@...com>,
Frédéric Weisbecker <fweisbec@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Hugh Dickins <hughd@...gle.com>,
Michel Lespinasse <walken@...gle.com>,
Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
Guan Xuetao <gxt@...c.pku.edu.cn>, aswin@...com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] mm: cache largest vma
* Davidlohr Bueso <davidlohr@...com> wrote:
> Btw, do you suggest using a high level tool such as perf for getting
> this data or sprinkling get_cycles() in find_vma() -- I'd think that the
> first isn't fine grained enough, while the later will probably variate a
> lot from run to run but the ratio should be rather constant.
LOL - I guess I should have read your mail before replying to it ;-)
Yes, I think get_cycles() works better in this case - not due to
granularity (perf stat will report cycle granular just fine), but due to
the size of the critical path you'll be measuring. You really want to
extract the delta, because it's probably so much smaller than the overhead
of the workload itself.
[ We still don't have good 'measure overhead from instruction X to
instruction Y' delta measurement infrastructure in perf yet, although
Frederic is working on such a trigger/delta facility AFAIK. ]
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists