linux-kernel - Re: [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Nov 2013 15:17:41 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, Chen Gong <gong.chen@...ux.intel.com>
Subject: Re: [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface

On Tue, Nov 05, 2013 at 10:59:36AM -0800, Luck, Tony wrote:
> -static int __einj_error_inject(u32 type, u64 param1, u64 param2)
> +static int __einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2,
> +			       u64 param3, u64 param4)

I wonder if, at some point in the future - not now, necessarily, it'll
be prudent to add an error injection struct descriptor which contains
all those param* thingies and some of them could even be defined as a
union in it in order to make the whole code more readable. Like the
'address' variable, for example, which is valid for multiple error
types...

Just an idea though, so let me throw it out in the open.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/