linux-kernel - Re: [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+8MBb+EBHPeB6ND4BjvaziuriAqjs-XxJyNCpBKK0b4SQptxQ@mail.gmail.com>
Date:	Wed, 6 Nov 2013 13:26:23 -0800
From:	Tony Luck <tony.luck@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Chen Gong <gong.chen@...ux.intel.com>
Subject: Re: [PATCH] Changes to the ACPI/APEI/EINJ debugfs interface

On Wed, Nov 6, 2013 at 6:17 AM, Borislav Petkov <bp@...en8.de> wrote:
> I wonder if, at some point in the future - not now, necessarily, it'll
> be prudent to add an error injection struct descriptor which contains
> all those param* thingies and some of them could even be defined as a
> union in it in order to make the whole code more readable. Like the
> 'address' variable, for example, which is valid for multiple error
> types...
>
> Just an idea though, so let me throw it out in the open.

That would indeed be a nice cleanup for later ... that many arguments
to a function is tickling my threshold for "this ought to be simpler".
Especially as we pass them all through einj_error_inject() on the way
to __einj_error_inject().  Perhaps don't even need a new structure,
just fill them into the existing set_error_type_with_address struct
(which is the format they need to be in to pass to the BIOS).

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/