linux-kernel - Re: [PATCH] staging: new asus fan driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131106143059.GA24451@srcf.ucam.org>
Date:	Wed, 6 Nov 2013 14:30:59 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: new asus fan driver

On Wed, Nov 06, 2013 at 12:55:56AM -0800, Greg Kroah-Hartman wrote:

> Matthew, please don't push drivers to the staging tree that have no
> problems on their own, and don't require work within them to get out of
> staging, as that doesn't help much, as I don't want to take code that
> has to wait for external things to happen before it can move out of
> staging.

I'm not willing to commit to supporting this code with the 
virt_to_phys() hack in place, but I also don't want to block Felipe from 
having an incentive to fix up the ACPI core so we can do this cleanly. 
What I suggested was adding it to the asus-wmi driver and wrapping the 
functionality with CONFIG_STAGING in order to indicate that there were 
no promises that this feature would remain, and then giving Felipe a few 
months to do the ACPI work. If it got done in a reasonable time then 
we'd keep the code, and if not I'd drop it. I certainly didn't suggest 
writing a separate driver, let alone putting it in staging.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/