linux-kernel - Re: [PATCH] usb: gadget: f_mass_storage: call try_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527B9A7F.8000006@linutronix.de>
Date:	Thu, 07 Nov 2013 14:49:51 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	George Cherian <george.cherian@...com>
CC:	balbi@...com, stern@...land.harvard.edu,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only
 when its safe

On 11/07/2013 02:37 PM, George Cherian wrote:
> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
> do_read() and do_write() calls sleep_thread with lock held.
> Make sure these wont call try_to_freeze() by passing can_freeze flag
> to sleep_thread.

Thank you. This is was Alan asked for and I forgot.

You could add

|Calling try_to_freeze() with a lock hold was done since day one in
|f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
|locks held at freeze time") lockdep complains about it.

so we have an explanation why it is suddenly a bad thing.

> Signed-off-by: George Cherian <george.cherian@...com>

Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/