linux-kernel - Re: [PATCH] usb: gadget: f_mass_storage: call try_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Nov 2013 19:35:14 +0530
From:	George Cherian <george.cherian@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	<balbi@...com>, <stern@...land.harvard.edu>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_mass_storage: call try_to_freeze only
 when its safe

On 11/7/2013 7:19 PM, Sebastian Andrzej Siewior wrote:
> On 11/07/2013 02:37 PM, George Cherian wrote:
>> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
>> do_read() and do_write() calls sleep_thread with lock held.
>> Make sure these wont call try_to_freeze() by passing can_freeze flag
>> to sleep_thread.
> Thank you. This is was Alan asked for and I forgot.
>
> You could add
>
> |Calling try_to_freeze() with a lock hold was done since day one in
> |f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
> |locks held at freeze time") lockdep complains about it.
>
> so we have an explanation why it is suddenly a bad thing.

okay will send v2 with commit log amend and your Acked-by
>
>> Signed-off-by: George Cherian <george.cherian@...com>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>
> Sebastian


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/