linux-kernel - Re: [PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <527AE9A5.8080003@cn.fujitsu.com>
Date:	Thu, 07 Nov 2013 09:15:17 +0800
From:	Duan Jiong <duanj.fnst@...fujitsu.com>
To:	Stephen Warren <swarren@...dotorg.org>, kernel@...gutronix.de,
	linux@....linux.org.uk, a.zummo@...ertech.it, airlied@...ux.ie
CC:	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
	Thierry Reding <treding@...dia.com>,
	Terje Bergström <tbergstrom@...dia.com>
Subject: Re: [PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

于 2013年11月07日 00:49, Stephen Warren 写道:
> On 11/06/2013 12:53 AM, Duan Jiong wrote:
>> This patch fixes coccinelle error regarding usage of IS_ERR and
>> PTR_ERR instead of PTR_ERR_OR_ZERO.
> 
>> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> 
>> @@ -199,10 +199,7 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm,
>>  
>>  	bo = tegra_bo_create_with_handle(file, drm, args->size, 0,
>>  					 &args->handle);
>> -	if (IS_ERR(bo))
>> -		return PTR_ERR(bo);
>> -
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(bo);
>>  }
> 
> I suppose that's fine, although I wonder if it'll cause churn should we
> ever need to add code to the tail end of the function.
> 
> BTW, why were all the similar patches that had nothing to do with Tegra
> sent to the linux-tegra@ mailing list? You also didn't CC the
> maintainers of drivers/gpu/drm/tegra/ on this patch. Plus this patch has
> nothing to do with the rtc-linux@ mailing list.

I'm sorry for that. i just get the maintainers and the mail lists by the script
get_maintainer.pl.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/