linux-kernel - Re: [trivial PATCH] module.h: Remove unnecessary semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1383868777.9263.39.camel@joe-AO722>
Date:	Thu, 07 Nov 2013 15:59:37 -0800
From:	Joe Perches <joe@...ches.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [trivial PATCH] module.h: Remove unnecessary semicolon

On Fri, 2013-11-08 at 09:41 +1030, Rusty Russell wrote:
> Joe Perches <joe@...ches.com> writes:
> > On Thu, 2013-11-07 at 12:32 +1030, Rusty Russell wrote:
> >> Joe Perches <joe@...ches.com> writes:
> >> > This semicolon isn't necessary, remove it.
> >> >
> >> > Signed-off-by: Joe Perches <joe@...ches.com>
> >> 
> >> This is a terrible description.  Really bad.
> >
> > I'd've preferred no description.
> 
> Me too.
> 
> >> First, it just repeats the subject, with more words.
> >
> > Which others have demanded.
> 
> They're wrong.

shrug.  Can't please everyone.

> >> Second, it gives me no indication that you've done a grep to make sure
> >> noone is abusing the macro, so I can't apply it without doing that check
> >> myself.
> >
> > That's a trust issue.
> > I've done it.  It isn't necessary.
> 
> WTF?  Now you just said it's not necessary, I *know* I can't trust you.

"It" in this case is the grep that I did
prior to sending the patch.

> > The other #define module_put_and_exit in a
> > different #if #else already doesn't have one.
> 
> You didn't mention this, and even if you did, it's not sufficient.  Some
> code only ever gets compiled as a module, so it'd never hit the
> !CONFIG_MODULES case.

Which would only show there was a latent bug.

> > Trust it or not, apply it or not.
> 
> Now I know when I receive a patch from you I have to check it carefully,
> because you can't be bothered.

Sure.  If you think so.
Nonetheless, I told you I'd checked it.

> I've fixed your patch, you can find it below.

No, not really fixed.  You modified the commit log to
suit your taste.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/