| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131108102113.GB6343@quack.suse.cz> Date: Fri, 8 Nov 2013 11:21:13 +0100 From: Jan Kara <jack@...e.cz> To: Frederic Weisbecker <fweisbec@...il.com> Cc: Steven Rostedt <rostedt@...dmis.org>, Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...e.cz> Subject: Re: [PATCH 3/4] printk: Defer printing to irq work when we printed too much On Fri 08-11-13 00:46:49, Frederic Weisbecker wrote: > On Thu, Nov 07, 2013 at 06:37:17PM -0500, Steven Rostedt wrote: > > On Fri, 8 Nov 2013 00:21:51 +0100 > > Frederic Weisbecker <fweisbec@...il.com> wrote: > > > > > > Offloading to a workqueue would be perhaps better, and writing to the serial > > > console could then be done with interrupts enabled, preemptible context, etc... > > > > Oh God no ;-) Adding workqueue logic into printk just spells a > > nightmare of much more complexity for a critical kernel infrastructure. > > But yeah that's scary, that means workqueues itself can't printk that safely. > So, you're right after all. Yeah, we've been there (that was actually my initial proposal). But Andrew and Steven (rightfully) objected and suggested irq_work should be used instead. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists