linux-kernel - Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Nov 2013 12:20:13 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: Prevent condition that all sort keys are
 elided


* Namhyung Kim <namhyung@...nel.org> wrote:

> From: Namhyung Kim <namhyung.kim@....com>
> 
> If given sort keys are all elided there'll be no output except for the
> overhead column - actually the TUI shows a noisy output.  In this case
> it'd be better to show up the sort keys rather than elide.
> 
> Before:
> 
>   $ perf report -s comm -c perf
>   (...)
>   # Overhead
>   # ........
>   #
>      100.00%
> 
> After:
> 
>   $ perf report -s comm -c perf
>   (...)
>   # Overhead  Command
>   # ........  .......
>   #
>      100.00%     perf
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/sort.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 3c1b75c8b9a6..fb7d556ad721 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -1137,6 +1137,8 @@ static void sort_entry__setup_elide(struct sort_entry *se,
>  
>  void sort__setup_elide(FILE *output)
>  {
> +	struct sort_entry *se;
> +
>  	sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list,
>  				"dso", output);
>  	sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list,
> @@ -1172,4 +1174,14 @@ void sort__setup_elide(FILE *output)
>  					"snoop", output);
>  	}
>  
> +	/*
> +	 * It makes no sense to elide all of sort entries.
> +	 * Just revert them to show up again.
> +	 */
> +	list_for_each_entry(se, &hist_entry__sort_list, list)
> +		if (!se->elide)
> +			return;

(Nit: please use curly braces around multi-line statements.)

> +
> +	list_for_each_entry(se, &hist_entry__sort_list, list)
> +		se->elide = false;

Looks good otherwise - this is the first step in the sort/key behavior 
improvements that we talked about a few days ago, right?

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/