linux-kernel - Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871u2mw0qr.fsf@sejong.aot.lge.com>
Date:	Tue, 12 Nov 2013 16:14:04 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

Hi Ingo,

On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@...nel.org> wrote:
>> +	/*
>> +	 * It makes no sense to elide all of sort entries.
>> +	 * Just revert them to show up again.
>> +	 */
>> +	list_for_each_entry(se, &hist_entry__sort_list, list)
>> +		if (!se->elide)
>> +			return;
>
> (Nit: please use curly braces around multi-line statements.)

Ah, okay.

>
>> +
>> +	list_for_each_entry(se, &hist_entry__sort_list, list)
>> +		se->elide = false;
>
> Looks good otherwise - this is the first step in the sort/key behavior 
> improvements that we talked about a few days ago, right?

Right.  And I'd like to wait bit more to hear other's opinion on this.

>
> Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/