linux-kernel - Re: [PATCH 05/11] metag: use generic fixmap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52824267.7010505@imgtec.com>
Date:	Tue, 12 Nov 2013 14:59:51 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Mark Salter <msalter@...hat.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-metag@...r.kernel.org>
Subject: Re: [PATCH 05/11] metag: use generic fixmap.h

On 12/11/13 13:22, Mark Salter wrote:
> Signed-off-by: Mark Salter <msalter@...hat.com>
> CC: James Hogan <james.hogan@...tec.com>
> CC: linux-metag@...r.kernel.org

Acked-by: James Hogan <james.hogan@...tec.com>

Thanks
James

> ---
>  arch/metag/include/asm/fixmap.h | 32 +-------------------------------
>  1 file changed, 1 insertion(+), 31 deletions(-)
> 
> diff --git a/arch/metag/include/asm/fixmap.h b/arch/metag/include/asm/fixmap.h
> index 3331275..af621b0 100644
> --- a/arch/metag/include/asm/fixmap.h
> +++ b/arch/metag/include/asm/fixmap.h
> @@ -51,37 +51,7 @@ enum fixed_addresses {
>  #define FIXADDR_SIZE	(__end_of_fixed_addresses << PAGE_SHIFT)
>  #define FIXADDR_START	((FIXADDR_TOP - FIXADDR_SIZE) & PMD_MASK)
>  
> -#define __fix_to_virt(x)	(FIXADDR_TOP - ((x) << PAGE_SHIFT))
> -#define __virt_to_fix(x)	((FIXADDR_TOP - ((x)&PAGE_MASK)) >> PAGE_SHIFT)
> -
> -extern void __this_fixmap_does_not_exist(void);
> -/*
> - * 'index to address' translation. If anyone tries to use the idx
> - * directly without tranlation, we catch the bug with a NULL-deference
> - * kernel oops. Illegal ranges of incoming indices are caught too.
> - */
> -static inline unsigned long fix_to_virt(const unsigned int idx)
> -{
> -	/*
> -	 * this branch gets completely eliminated after inlining,
> -	 * except when someone tries to use fixaddr indices in an
> -	 * illegal way. (such as mixing up address types or using
> -	 * out-of-range indices).
> -	 *
> -	 * If it doesn't get removed, the linker will complain
> -	 * loudly with a reasonably clear error message..
> -	 */
> -	if (idx >= __end_of_fixed_addresses)
> -		__this_fixmap_does_not_exist();
> -
> -	return __fix_to_virt(idx);
> -}
> -
> -static inline unsigned long virt_to_fix(const unsigned long vaddr)
> -{
> -	BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START);
> -	return __virt_to_fix(vaddr);
> -}
> +#include <asm-generic/fixmap.h>
>  
>  #define kmap_get_fixmap_pte(vaddr) \
>  	pte_offset_kernel( \
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/