linux-kernel - [PATCH] Silence r8712u info and add verbose option v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Nov 2013 13:43:13 -0500
From:	Alexandre Demers <alexandre.f.demers@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Silence r8712u info and add verbose option v2

r8712u pollutes dmesg and logs. Silence it and add a verbose option to KConfig if we ever 
really want to hear about it.

v2: keep netdev_info instead of replacing it by a KERN_NOTICE

---
 drivers/staging/rtl8712/Kconfig        | 7 +++++++
 drivers/staging/rtl8712/rtl871x_mlme.c | 7 ++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
index 6a43312..7cae8f8 100644
--- a/drivers/staging/rtl8712/Kconfig
+++ b/drivers/staging/rtl8712/Kconfig
@@ -16,4 +16,11 @@ config R8712_TX_AGGR
 	---help---
 	This option provides transmit aggregation for the Realtek RTL8712 USB device.
 
+config R8712U_DEBUG
+	bool "Realtek RTL8712U Wireless verbose debug"
+	depends on R8712U
+	help
+	  Say Y here in order to have the rtl8712u code generate
+	  verbose debugging messages.
+
 
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 6596154..1226009 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -1043,9 +1043,12 @@ void r8712_got_addbareq_event_callback(struct _adapter *adapter, u8 *pbuf)
 	struct	sta_priv *pstapriv = &adapter->stapriv;
 	struct	recv_reorder_ctrl *precvreorder_ctrl = NULL;
 
+#ifdef CONFIG_R8712U_DEBUG
	netdev_info(adapter->pnetdev, "%s: mac = %pM, seq = %d, tid = %d\n",
		    __func__, pAddbareq_pram->MacAddress,
	    pAddbareq_pram->StartSeqNum, pAddbareq_pram->tid);
+#endif
+
 	psta = r8712_get_stainfo(pstapriv, pAddbareq_pram->MacAddress);
 	if (psta) {
 		precvreorder_ctrl =
-- 
1.8.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/