linux-kernel - Re: [PATCH] Silence r8712u info and add verbose option v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52827E16.1030001@lwfinger.net>
Date:	Tue, 12 Nov 2013 13:14:30 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alexandre Demers <alexandre.f.demers@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Silence r8712u info and add verbose option v2

On 11/12/2013 12:43 PM, Alexandre Demers wrote:
> r8712u pollutes dmesg and logs. Silence it and add a verbose option to KConfig if we ever
> really want to hear about it.
>
> v2: keep netdev_info instead of replacing it by a KERN_NOTICE
>
> ---
>   drivers/staging/rtl8712/Kconfig        | 7 +++++++
>   drivers/staging/rtl8712/rtl871x_mlme.c | 7 ++++---
>   2 files changed, 11 insertions(+), 3 deletions(-)

Do you really want the "v2" to be part of the patch title in the git repos? I 
expect not, thus you should put it inside the []. All that stuff is stripped off 
when the patch is merged.

Similarly, do you want the v2 line in the patch description to be part of the 
permanent record? If not, move it below the --- line.

You are also missing a Signed-off-by: line. Have you read 
Documentation/SubmittingPatches? At least you should run every patch through 
scripts/checkpatch.pl before submitting it.

Finally, why do you want to add another Kconfig variable? I suggest either 
deleting the logging statement, or commenting it out. I'm not sure that this 
info would ever need logging.

I NACK this patch.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/