linux-kernel - Re: [PATCH] spi: spi-gpio: Add check for cs-gpios dt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131113133320.GL878@sirena.org.uk>
Date:	Wed, 13 Nov 2013 13:33:20 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Gerlando Falauto <gerlando.falauto@...mile.com>
Cc:	linux-kernel@...r.kernel.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH] spi: spi-gpio: Add check for cs-gpios dt property

On Wed, Nov 13, 2013 at 09:02:28AM +0100, Gerlando Falauto wrote:
> The bindings assumed that the cs-gpios property is always there.
> However, a single SPI device can also work fine without an explicit chip select.
> Use the SPI_GPIO_NO_CHIPSELECT mode when the property is not present or invaild.

Given that for most systems a missing /CS would be an error it seems
better to add an explicit property to enable this in order to help make
problems with the more common case more obvious.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)