linux-kernel - Re: [PATCH 1/2] ARM: default PHYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131113133952.GW14892@pengutronix.de>
Date:	Wed, 13 Nov 2013 14:39:52 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Jonathan Austin <jonathan.austin@....com>
Cc:	Ming Lei <tom.leiming@...il.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Russell King <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU

On Wed, Nov 13, 2013 at 11:46:49AM +0000, Jonathan Austin wrote:
> Hi Ming,
> 
> On 13/11/13 11:15, Ming Lei wrote:
> > From: Jonathan Austin <jonathan.austin@....com>
> > 
> > Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
> > we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
> >
> 
> I'm not so sure about this commit message - I don't think
> it makes sense...Should it not be more like:
> 
> ------->8-------
> Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
> 
> With !MMU we still set PAGE_OFFSET to 0xC0000000, which
> makes little sense and causes a regression on !MMU after
> f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
> kernel address space")
> 
> This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
> case, fixing the regression (Tested on Cortex-R7/Vexpress)
> --------8<---------
I like this commit log better, too.

As CONFIG_PAGE_OFFSET is only used in scripts/kallsyms.c and
scripts/link-vmlinux.sh for !MMU.

Booting on efm32 with this patch works just fine, so if you want add my
Tested-by. But I'm unsure how valuable it is as I don't see a breakage
without it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/