linux-kernel - Re: [PATCH V3] usbnet: fix race condition caused spinlock bad magic issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384415082.18291.8.camel@linux-fkkt.site>
Date:	Thu, 14 Nov 2013 08:44:42 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	wangbiao <biao.wang@...el.com>
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo.kernel.org@...il.com>,
	akpm@...ux-foundation.org, mingo@...e.hu, a.p.zijlstra@...llo.nl,
	rusty@...tcorp.com.au, william.douglas@...el.com,
	di.zhang@...el.com
Subject: Re: [PATCH V3] usbnet: fix race condition caused spinlock bad
 magic issue

On Thu, 2013-11-14 at 10:03 +0800, wangbiao wrote:
> From: wang, biao <biao.wang@...el.com>
> Date: Mon, 11 Nov 2013 10:23:40 +0800
> Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue
> 
> there is race between usbnet_terminate_urbs and usbnet_bh.
> for example:
>     cpu 0                                     cpu 1
>                                           usbnet_suspend
> usbnet_bh {                               ->usbnet_terminate_urbs {
>                                               dev->wait = &unlink_wakeup;
>                                               while(....){..}//break
>     if(dev->wait) is true
>                        		              dev->wait=NULL
>                                           }//unlink_wakeup is invalid
>     __wake_up(dev->wait)//garbage value
> }
> 
> the race is due to unprotection of dev->wait, so this patch involves a
> spinlock to avoid it.
> 
> Signed-off-by: wang, biao <biao.wang@...el.com>
> Signed-off-by: Zhang, Di <di.zhang@...el.com>
Acked-by: Oliver Neukum <oliver@...kum.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/