linux-kernel - Re: [PATCH v2] sched: Check sched_domain before computing group power.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131114083037.GT21461@twins.programming.kicks-ass.net>
Date:	Thu, 14 Nov 2013 09:30:37 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
Cc:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Preeti Murthy <preeti.lkml@...il.com>, mingo@...nel.org,
	hpa@...or.com, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>, mikey@...ling.org,
	linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH v2] sched: Check sched_domain before computing group
 power.

On Thu, Nov 14, 2013 at 11:36:27AM +0530, Preeti U Murthy wrote:
> However I was thinking that a better fix would be to reorder the way we call
> update_group_power() and cpu_attach_domain(). Why do we need to do
> update_group_power() of the groups of the sched domains that would probably
> degenerate in cpu_attach_domain()? So it seemed best to move update_group_power()
> to after cpu_attach_domain() so that it saves unnecessary iterations over
> sched domains which could degenerate, and it fixes the issue that you have brought out
> as well. See below for the patch:

So how is publishing the domain tree before we've set these values at
all going to help avoid the divide-by-zero problem?

Also its just terribly bad form to publish something before you're done
with initialization.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/