linux-kernel - Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 01:07:30 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org,
	linus.walleij@...aro.org, grant.likely@...retlab.ca,
	horms@...ge.net.au
Subject: Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

Hi Magnus,

Thank you for the patch.

On Thursday 14 November 2013 07:59:36 Magnus Damm wrote:
> From: Magnus Damm <damm@...nsource.se>
> 
> Set the ->irq_enable() and ->irq_disable() methods to NULL
> to enable lazy disable of interrupts.

Is that just for optimization purpose, or is there another reason ?

> Also extend the code to set IRQCHIP_MASK_ON_SUSPEND which tells the core
> that only IRQs marked as wakeups need to stay enabled during Suspend-to-RAM.

Shouldn't this be split to a separate patch ?

> Tested on the Lager board with GPIO-keys and Suspend-to-RAM.
> 
> Signed-off-by: Magnus Damm <damm@...nsource.se>
> ---
> 
>  drivers/gpio/gpio-rcar.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- 0001/drivers/gpio/gpio-rcar.c
> +++ work/drivers/gpio/gpio-rcar.c	2013-11-13 19:26:26.000000000 +0900
> @@ -368,10 +368,9 @@ static int gpio_rcar_probe(struct platfo
>  	irq_chip->name = name;
>  	irq_chip->irq_mask = gpio_rcar_irq_disable;
>  	irq_chip->irq_unmask = gpio_rcar_irq_enable;
> -	irq_chip->irq_enable = gpio_rcar_irq_enable;
> -	irq_chip->irq_disable = gpio_rcar_irq_disable;
>  	irq_chip->irq_set_type = gpio_rcar_irq_set_type;
>  	irq_chip->flags	= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED;
> +	irq_chip->flags	|= IRQCHIP_MASK_ON_SUSPEND;

You can write it as

        irq_chip->flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED
                        | IRQCHIP_MASK_ON_SUSPEND;

>  	p->irq_domain = irq_domain_add_simple(pdev->dev.of_node,
>  					      p->config.number_of_pins,
-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/