linux-kernel - Re: [PATCH 4/4] arm64: advertise CPU features for modalias matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a4ebc9e-3dba-4911-adbe-3097d131793b@email.android.com>
Date:	Thu, 14 Nov 2013 11:05:54 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>
CC:	"x86@...nel.org" <x86@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"steve.capper@...aro.org" <steve.capper@...aro.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	Dave P Martin <Dave.Martin@....com>
Subject: Re: [PATCH 4/4] arm64: advertise CPU features for modalias matching

arch/what again?

Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:
>On 14 November 2013 16:29, Catalin Marinas <catalin.marinas@....com>
>wrote:
>> On Mon, Nov 11, 2013 at 10:19:35AM +0000, Ard Biesheuvel wrote:
>>> +ssize_t arch_print_cpu_modalias(struct device *dev,
>>> +                             struct device_attribute *attr,
>>> +                             char *buf)
>>> +{
>>> +     unsigned int caps;
>>> +     ssize_t n;
>>> +     int i;
>>> +
>>> +     /*
>>> +      * With 32 features maximum (taking 5 bytes each to print), we
>don't
>>> +      * need to worry about overrunning the PAGE_SIZE sized buffer.
>>> +      */
>>> +     n = sprintf(buf, "cpu:type:arm64:feature:");
>>
>> I would use "aarch64" here instead of arm64 for consistency with the
>> architecture mode, compiler triplet and ELF_PLATFORM definition in
>the
>> kernel.
>
>OK, I will change that.
>
>Regards,
>Ard,

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/