[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGG-pUT22xoksid-2GmJsDmVQk8gR8zHvAr=r3Z2E4BLf+1jJA@mail.gmail.com>
Date: Fri, 15 Nov 2013 11:00:54 -0200
From: Geyslan Gregório Bem <geyslan@...il.com>
To: Caizhiyong <caizhiyong@...ilicon.com>
Cc: Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Wanglin (Albert)" <albert.wanglin@...ilicon.com>,
Levente Kurusa <ilevex.linux@...il.com>
Subject: Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value
2013/11/15 Caizhiyong <caizhiyong@...ilicon.com>:
> From: Cai Zhiyong <caizhiyong@...wei.com>
> Date: Mon, 11 Nov 2013 19:26:14 +0800
> Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value
>
> This patch give a warning when calling regmap_register_patch with
> parameter num_regs <= 0.
>
> When the num_regs parameter is zero and krealloc doesn't fail,
> then the code would return an uninitialized value. However,
> calling this function with num_regs == 0, would be a waste as it
> essentially does nothing.
>
> Signed-off-by: Cai Zhiyong <caizhiyong@...wei.com>
Reviewed-by: Geyslan G. Bem <geyslan@...il.com>
Seems a good approach.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists