linux-kernel - Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Nov 2013 22:26:41 +0900
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	devel@...verdev.osuosl.org,
	Johan Hedberg <johan.hedberg@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Yu-Chen Cho <acho@...e.com>,
	"linux-kernel@...r.kernel.org list" <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org development" 
	<linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

Hi Dan,

>> while this is patch is correct, I do not really care about staging drivers that actually bluntly violate my copyright.
>> 
> 
> That's very cryptic.
> 
> What is going on here?  I googled it and I wasn't able to find what you
> are talking about.  Care to give us a hint and what you want us to do
> here?

the last time I checked, the majority of drivers/bluetooth/btusb.c has been written by myself. Now go and compare btusb.c to btmtk_usb.[ch].

> I have also added Johan Hedberg to the CC list because he also helped
> break the build.  Don't do that.

Yes, we are doing exactly that. It is a staging driver. I could not care less if a staging drivers breaks the build or not.

If anybody cares about this driver, then take the time to merge it upstream. It has never been submitted to linux-bluetooth mailing list.

There are drivers that should have never been merged into staging. This is one of them. Look for yourself and explain to me why this driver is part of staging in the first place.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/