linux-kernel - Re: [PATCH] brcmsmac: Fix build dep on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5289359B.8090506@broadcom.com>
Date:	Sun, 17 Nov 2013 22:31:07 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Borislav Petkov" <bp@...en8.de>
cc:	lkml <linux-kernel@...r.kernel.org>,
	Rafał Miłecki <zajec5@...il.com>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

On 11/17/13 14:37, Borislav Petkov wrote:
> From: Borislav Petkov<bp@...e.de>
>
> When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get
>
> drivers/built-in.o: In function `brcms_led_unregister':
> (.text+0x351aca): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `brcms_led_register':
> (.text+0x351c65): undefined reference to `led_classdev_register'
>
> during the final linking stage because brcmsmac/led.c needs LEDS_CLASS
> for reg/dereg. Fix that.

Wouldn't it be better to fix it in brcmsmac.

Gr AvS

> Cc: "Rafał Miłecki"<zajec5@...il.com>
> Cc: linux-wireless@...r.kernel.org
> Signed-off-by: Borislav Petkov<bp@...e.de>
> ---
>
> I'm attaching the .config in question.
>
>   drivers/bcma/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index 7c081b38ef3e..74dba9ca1413 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -74,7 +74,7 @@ config BCMA_DRIVER_GMAC_CMN
>
>   config BCMA_DRIVER_GPIO
>   	bool "BCMA GPIO driver"
> -	depends on BCMA&&  GPIOLIB
> +	depends on BCMA&&  GPIOLIB&&  LEDS_CLASS
>   	help
>   	  Driver to provide access to the GPIO pins of the bcma bus.
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/