linux-kernel - [PATCH] brcmsmac: Fix build dep on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Nov 2013 14:37:02 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	linux-wireless@...r.kernel.org
Subject: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

From: Borislav Petkov <bp@...e.de>

When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get

drivers/built-in.o: In function `brcms_led_unregister':
(.text+0x351aca): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `brcms_led_register':
(.text+0x351c65): undefined reference to `led_classdev_register'

during the final linking stage because brcmsmac/led.c needs LEDS_CLASS
for reg/dereg. Fix that.

Cc: "Rafał Miłecki" <zajec5@...il.com>
Cc: linux-wireless@...r.kernel.org
Signed-off-by: Borislav Petkov <bp@...e.de>
---

I'm attaching the .config in question.

 drivers/bcma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 7c081b38ef3e..74dba9ca1413 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -74,7 +74,7 @@ config BCMA_DRIVER_GMAC_CMN
 
 config BCMA_DRIVER_GPIO
 	bool "BCMA GPIO driver"
-	depends on BCMA && GPIOLIB
+	depends on BCMA && GPIOLIB && LEDS_CLASS
 	help
 	  Driver to provide access to the GPIO pins of the bcma bus.
 
-- 
1.8.4


-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

View attachment "13-48-11-randconfig-x86_64-9031.cfg" of type "text/plain" (78893 bytes)