linux-kernel - Re: [PATCH 1/4] clocksource: arm_global_timer: Switch to sched_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528A5498.4030501@st.com>
Date:	Mon, 18 Nov 2013 17:55:36 +0000
From:	Stuart MENEFY <stuart.menefy@...com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	linux-kernel@...r.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@...com>
Subject: Re: [PATCH 1/4] clocksource: arm_global_timer: Switch to sched_clock_register()

Looks good, thanks.

Acked-by: Stuart Menefy <stuart.menefy@...com>

On 15/11/13 23:48, Stephen Boyd wrote:
> The 32 bit sched_clock interface now supports 64 bits. Upgrade to
> the 64 bit function to allow us to remove the 32 bit registration
> interface. While we're here increase the number of bits that
> sched_clock can handle to 64 to make full use of the counter.
> 
> Cc: Stuart Menefy <stuart.menefy@...com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
>  drivers/clocksource/arm_global_timer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
> index c639b1a..0fc31d0 100644
> --- a/drivers/clocksource/arm_global_timer.c
> +++ b/drivers/clocksource/arm_global_timer.c
> @@ -202,7 +202,7 @@ static struct clocksource gt_clocksource = {
>  };
>  
>  #ifdef CONFIG_CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> -static u32 notrace gt_sched_clock_read(void)
> +static u64 notrace gt_sched_clock_read(void)
>  {
>  	return gt_counter_read();
>  }
> @@ -217,7 +217,7 @@ static void __init gt_clocksource_init(void)
>  	writel(GT_CONTROL_TIMER_ENABLE, gt_base + GT_CONTROL);
>  
>  #ifdef CONFIG_CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> -	setup_sched_clock(gt_sched_clock_read, 32, gt_clk_rate);
> +	sched_clock_register(gt_sched_clock_read, 64, gt_clk_rate);
>  #endif
>  	clocksource_register_hz(&gt_clocksource, gt_clk_rate);
>  }
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/