linux-kernel - Re: [PATCH] mfd: Make MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVkWmYGM5XvH0f41JdwK_g-PdvdDBzR8uJWn0wYBQrAcg@mail.gmail.com>
Date:	Tue, 19 Nov 2013 09:20:41 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Michal Marek <mmarek@...e.cz>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, ldewangan@...dia.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] mfd: Make MFD_AS3722 depend on I2C=y

On Tue, Nov 19, 2013 at 12:19 AM, Stephen Warren <swarren@...dotorg.org> wrote:
> On 11/18/2013 10:25 AM, Michal Marek wrote:
>> MFD_AS3722 can only be builtin, so it needs I2C builtin as well.
>> With I2C=m, we get:
>>
>> drivers/mfd/as3722.c:372: undefined reference to `devm_regmap_init_i2c'
>> drivers/built-in.o: In function `as3722_i2c_driver_init':
>> drivers/mfd/as3722.c:444: undefined reference to `i2c_register_driver'
>> drivers/built-in.o: In function `as3722_i2c_driver_exit':
>> drivers/mfd/as3722.c:444: undefined reference to `i2c_del_driver'
>
> Shouldn't Kconfig handle this; if a Boolean config option depends on a
> tri-state config option, shouldn't it automatically validate that the
> tri-state is "y" not "m"?

Unfortunately not. While tristate is always used to declare code modules,
bool can be used to declare two different things: code modules or optional
features.

For optional features, "depends on x" means "depends on x=y or x=m".
For code modules, "depends on x" should really by "depends on x=y".

To handle this automatically, we need to introduce a new Kconfig symbol,
and convert all the thousands existing ones...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/