linux-kernel - Re: [PATCH] mfd: Make MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528B17DC.9020004@suse.cz>
Date:	Tue, 19 Nov 2013 08:48:44 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org, ldewangan@...dia.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Make MFD_AS3722 depend on I2C=y

On 19.11.2013 00:19, Stephen Warren wrote:
> On 11/18/2013 10:25 AM, Michal Marek wrote:
>> MFD_AS3722 can only be builtin, so it needs I2C builtin as well.
>> With I2C=m, we get:
>>
>> drivers/mfd/as3722.c:372: undefined reference to `devm_regmap_init_i2c'
>> drivers/built-in.o: In function `as3722_i2c_driver_init':
>> drivers/mfd/as3722.c:444: undefined reference to `i2c_register_driver'
>> drivers/built-in.o: In function `as3722_i2c_driver_exit':
>> drivers/mfd/as3722.c:444: undefined reference to `i2c_del_driver'
> 
> Shouldn't Kconfig handle this; if a Boolean config option depends on a
> tri-state config option, shouldn't it automatically validate that the
> tri-state is "y" not "m"?

That's what I initially though as well. But then you have cases where
intuitively you prefer the current m -> y promotion:

config EXT3_FS
	tristate "Ext3 journalling file system support"

config EXT3_DEFAULTS_TO_ORDERED
	bool "Default to 'data=ordered' in ext3"
	depends on EXT3_FS
	default y

Ternary logic is fun only as long as it is not mixed with boolean :-(.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/