linux-kernel - Re: linux-next: Tree for Nov 15 (target_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528BA90D.5070009@infradead.org>
Date:	Tue, 19 Nov 2013 10:08:13 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	target-devel <target-devel@...r.kernel.org>, kmo@...erainc.com,
	Tejun Heo <tj@...nel.org>
Subject: Re: linux-next: Tree for Nov 15 (target_core_mod)

On 11/18/13 11:46, Nicholas A. Bellinger wrote:
> On Fri, 2013-11-15 at 09:41 -0800, Randy Dunlap wrote:
>> On 11/14/13 21:24, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Please do *not* add any v3.14 material to linux-next until after
>>> v3.13-rc1 is released.
>>>
>>> Changes since 20131114:
>>>
>>
>>
>> on i386:
>>
>>
>> ERROR: "percpu_ref_cancel_init" [drivers/target/target_core_mod.ko] undefined!
>> ERROR: "percpu_ref_kill_and_confirm" [drivers/target/target_core_mod.ko] undefined!
>> ERROR: "percpu_ref_init" [drivers/target/target_core_mod.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>>
> 
> Mmmm, confirmed that lib/Makefile not including percpu-refcount.o in
> obj-y is the problem here..  (CC'ing Tejun + Kent).
> 
> Applying the following patch to target-pending/for-next now..
> 
> --nab
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index f3bb2cb..eaa946d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -26,7 +26,7 @@ obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
>          bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
>          gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \
>          bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
> -        percpu_ida.o
> +        percpu-refcount.o percpu_ida.o
>  obj-y += string_helpers.o
>  obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
>  obj-y += kstrtox.o
> 
> --

That does fix the build errors.  Thanks.

Here is a more complete patch with a patch description and S-O-B.
I would have put your S-O-B in it but you didn't include one.
Feel free to add yours now.

---
From: Randy Dunlap <rdunlap@...radead.org>

Drop percpu_ida.o from lib-y since it is also listed in obj-y
and it doesn't need to be listed in both places.

Move percpu-refcount.o from lib-y to obj-y to fix build errors
in target_core_mod:

ERROR: "percpu_ref_cancel_init" [drivers/target/target_core_mod.ko] undefined!
ERROR: "percpu_ref_kill_and_confirm" [drivers/target/target_core_mod.ko] undefined!
ERROR: "percpu_ref_init" [drivers/target/target_core_mod.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
 lib/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20131115.orig/lib/Makefile
+++ linux-next-20131115/lib/Makefile
@@ -13,7 +13,7 @@ lib-y := ctype.o string.o vsprintf.o cmd
 	 sha1.o md5.o irq_regs.o reciprocal_div.o argv_split.o \
 	 proportions.o flex_proportions.o prio_heap.o ratelimit.o show_mem.o \
 	 is_single_threaded.o plist.o decompress.o kobject_uevent.o \
-	 earlycpio.o percpu-refcount.o percpu_ida.o
+	 earlycpio.o
 
 obj-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
 lib-$(CONFIG_MMU) += ioremap.o
@@ -26,7 +26,7 @@ obj-y += bcd.o div64.o sort.o parser.o h
 	 bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \
 	 gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \
 	 bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \
-	 percpu_ida.o
+	 percpu-refcount.o percpu_ida.o
 obj-y += string_helpers.o
 obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
 obj-y += kstrtox.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/