linux-kernel - Re: [RFC 01/23] gpio/omap: raw read and write endian fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mwl0mfa0.fsf@linaro.org>
Date:	Tue, 19 Nov 2013 10:12:55 -0800
From:	Kevin Hilman <khilman@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Taras Kondratiuk <taras.kondratiuk@...aro.org>,
	ext Tony Lindgren <tony@...mide.com>,
	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Linux-OMAP <linux-omap@...r.kernel.org>,
	linaro-networking@...aro.org,
	Victor Kamensky <victor.kamensky@...aro.org>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	"linux-gpio\@vger.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 01/23] gpio/omap: raw read and write endian fix

Linus Walleij <linus.walleij@...aro.org> writes:

> On Sat, Nov 16, 2013 at 1:01 AM, Taras Kondratiuk
> <taras.kondratiuk@...aro.org> wrote:
>
>> From: Victor Kamensky <victor.kamensky@...aro.org>
>>
>> All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
>> Need to use endian neutral functions to read/write h/w registers.
>> I.e instead of __raw_read[lw] and __raw_write[lw] functions code
>> need to use read[lw]_relaxed and write[lw]_relaxed functions.
>> If the first simply reads/writes register, the second will byteswap
>> it if host operates in BE mode.
>>
>> Changes are trivial sed like replacement of __raw_xxx functions
>> with xxx_relaxed variant.
>>
>> Signed-off-by: Victor Kamensky <victor.kamensky@...aro.org>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@...aro.org>
>
> Since I generally just dislike __raw accessors I went and applied
> this. If it collides with any of Tony's fixup work I might need to
> take the patch out again, no big deal.
>
> Some ACKs would be nice, but unless there are major objections
> this stays merged.

Acked-by: Kevin Hilman <khilman@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/