linux-kernel - Re: [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5115264.27yxWCajFa@vostro.rjw.lan>
Date:	Tue, 19 Nov 2013 21:52:17 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration

On Tuesday, November 19, 2013 10:23:57 AM Bjorn Helgaas wrote:
> On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> > Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users
> > of acpiphp_debug variable and the variable itself but the declaration was
> > left in the header file. Drop this unused declaration.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> 
> Rafael, if it makes sense for you to apply this, you can add my:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Otherwise I can pick it up.

Applied, thanks!

I'm going to send my next pull request tomorrow.

> > ---
> >  drivers/pci/hotplug/acpiphp.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> > index 26100f510b10..1592dbe4f904 100644
> > --- a/drivers/pci/hotplug/acpiphp.h
> > +++ b/drivers/pci/hotplug/acpiphp.h
> > @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
> >  u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
> >
> >  /* variables */
> > -extern bool acpiphp_debug;
> >  extern bool acpiphp_disabled;
> >
> >  #endif /* _ACPIPHP_H */
> > --
> > 1.8.4.3
> >
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/