linux-kernel - Re: [PATCH] [SCSI] bnx2i: add a prefix to a printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvx1B=TMcnDdYHHMDydSLSJ5FPaWnQXDZDBEpNEBzXp3QQ@mail.gmail.com>
Date:	Thu, 21 Nov 2013 09:44:45 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Eddie Wai <eddie.wai@...adcom.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] [SCSI] bnx2i: add a prefix to a printk

On Thu, Nov 21, 2013 at 9:34 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> (Eddie was added as maintainer a few months ago, so Eddie receives this
> message too.)
>
> On Wed, 2012-06-27 at 21:26 +0200, Paul Bolle wrote:
>> During each suspend and resume cycle a mysterious message is added to
>> the logs:
>>     CPU 1 offline: Remove Rx thread
>>
>> Some grepping of the tree revealed this message is printed by bnx2i.
>> Add a prefix to this message to make it clear that it is printed by
>> bnx2i. That should also make it obvious it is the mirror of the
>>     bnx2i: CPU 1 online: Create Rx thread
>>
>> message.
>>
>> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
>
> This issue is still present. Could someone please have a look at this
> patch?

What issue? There is no issue...

If you really want to help, remove the hotcpu notifier at all and
convert the driver to smpboot.
This would be a) a useful commit and b) helps tglx with his cpu hotplug work.

>> 0) Untested!
>
> It's tested now (on top of v3.12.1).
>
>> 1) I only noticed this because I've been looking at the log messages
>> generated by suspend and resume (for some iwlegacy and i915 issues) and
>> because Fedora 16 enables bnx2i by default.
>
> Fedora 18 still enables bnx2i by default.
>
>> 2) This triggers a checkpatch warning:
>>     WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
>>
>> So I added Joe to the Cc's to suggest a way to make all printks in this
>> file end up with a "bnx2i:" prefix (or whatever prefix is preferred).
>>
>>  drivers/scsi/bnx2i/bnx2i_init.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
>> index 8b68167..b75864b 100644
>> --- a/drivers/scsi/bnx2i/bnx2i_init.c
>> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
>> @@ -456,7 +456,8 @@ static int bnx2i_cpu_callback(struct notifier_block *nfb,
>>               break;
>>       case CPU_DEAD:
>>       case CPU_DEAD_FROZEN:
>> -             printk(KERN_INFO "CPU %x offline: Remove Rx thread\n", cpu);
>> +             printk(KERN_INFO "bnx2i: CPU %x offline: Remove Rx thread\n",
>> +                     cpu);
>>               bnx2i_percpu_thread_destroy(cpu);
>>               break;
>>       default:
>
>
> Paul Bolle
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/