linux-kernel - Re: [PATCH] mm/bootmem.c: remove unused 'limit' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131121203707.4f59f86e@redhat.com>
Date:	Thu, 21 Nov 2013 20:37:07 -0500
From:	Luiz Capitulino <lcapitulino@...hat.com>
To:	Dave Hansen <dave.hansen@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] mm/bootmem.c: remove unused 'limit' variable

On Thu, 21 Nov 2013 14:05:42 -0800
Dave Hansen <dave.hansen@...el.com> wrote:

> On 11/21/2013 01:43 PM, Luiz Capitulino wrote:
> > @@ -655,9 +655,7 @@ restart:
> >  void * __init __alloc_bootmem_nopanic(unsigned long size, unsigned long align,
> >  					unsigned long goal)
> >  {
> > -	unsigned long limit = 0;
> > -
> > -	return ___alloc_bootmem_nopanic(size, align, goal, limit);
> > +	return ___alloc_bootmem_nopanic(size, align, goal, 0);
> >  }
> 
> FWIW, I like those.  The way you leave it:
> 
> 	return ___alloc_bootmem_nopanic(size, align, goal, 0);
> 
> the 0 is a magic number that you have to go look up the declaration of
> ___alloc_bootmem_nopanic() to decipher, or you have to add a comment to
> it in some way.
> 
> I find it much more readable to have an 'unused' variable like that.

Got it. I was reading that code and thought 'limit' was a leftover,
so I posted the patch...

Btw, I also have a patch consitfying some zone access functions
parameters that are read-only. Wondering if anyone will object
to such a change? Or maybe I should just stop doing trivial patches :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/